Add llm artifact upload step (test results artifacts) #51890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbp
added
the
Central-EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR adds infrastructure to upload test results artifacts (.trx files) for LLM consumption, enabling external analysis tools to access test data without authentication requirements. This is intended to support pipeline analysis for GitHub Copilot and partner developers.
- Adds a new template step to collect and organize .trx test result files
- Integrates the collection step into the CI test pipeline with conditional artifact upload
- Creates a standardized naming convention for test artifacts to facilitate parsing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/pipelines/templates/steps/upload-llm-artifacts.yml | New template that collects .trx files and renames them with service/package identifiers |
| eng/pipelines/templates/jobs/ci.tests.yml | Integrates the LLM artifact upload step and adds conditional artifact publishing |
weshaggard
reviewed
Aug 12, 2025
| @@ -73,6 +73,11 @@ jobs: | |||
| artifactName: "Crash Dump - $(System.JobName) - $(System.JobAttempt)" | |||
| condition: eq(variables['uploadDump'], 'true') | |||
| sbomEnabled: false | |||
| - output: pipelineArtifact | |||
| targetPath: '$(Build.ArtifactStagingDirectory)/llm-artifacts' | |||
| artifactName: "LLM Artifacts - $(System.JobName) - $(System.JobAttempt)" | |||
There was a problem hiding this comment.
Do we want to have this LLM specific artifact? I know we talked about it but don't remember what we decided?
weshaggard
reviewed
Aug 12, 2025
| $fileFullName = $testResultsFile.FullName | ||
|
|
||
| # Convert a path like | ||
| # /mnt/vss/_work/1/s/sdk/template/Azure.Template/tests/TestResults/net8.0.trx |
There was a problem hiding this comment.
Is it possible to update the trx file name at the source?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pipeline step to upload the
.trx(xml) files from tests as a devops artifact. This allows the azsdk cli/mcp to fetch the artifacts and parse them for analysis.This is necessary as we would like to support pipeline analysis for the github coding agent and/or partner developers without any auth requiremnts. The devops test results API requires auth, even for public projects, otherwise we would be able to use that directly like we do in for the
azsdk azp analyze --agentflow.I'm using a more generic naming (llm artifacts) as we may end up wanting to upload other generic files for use by LLMs in the future.